[#386] Rename PascalCase C identifiers to snake_case and add naming c…#387
Draft
rhusar wants to merge 1 commit into
Draft
[#386] Rename PascalCase C identifiers to snake_case and add naming c…#387rhusar wants to merge 1 commit into
rhusar wants to merge 1 commit into
Conversation
…d naming convention CI check Signed-off-by: Radoslav Husar <radosoft@gmail.com>
jajik
requested changes
May 18, 2026
| code=0 | ||
| cd mod_proxy_cluster/native | ||
| for file in */*.c */*.h; do | ||
| output=$(clang-tidy --checks='-*,readability-identifier-naming' "$file" -- -I/usr/include/apache2 -I/usr/include/apr-1.0 2>&1 | grep 'warning:.*identifier naming' || true) |
Member
There was a problem hiding this comment.
This does not work. When clang-tidy encounters an error before finding anything, this will report OK without checking the file.
This also expects apache and apr installed, so maybe it should depend on some compilation job (see perl tests).
rhusar
marked this pull request as draft
July 21, 2026 13:56
Member
Author
|
Making this a draft until we merge the refactor PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onvention CI check
Lets fix this mess.